Bug 162031

Summary:

Fix missing JSMediaStreamTrackSourcesCallback.cpp

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

WebCore Misc.

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Windows 10

Attachments:

Description	Flags
patch	ysuzuki: review+
patch	commit-queue: commit-queue-

JF Bastien

Reported 2016-09-15 13:30:44 PDT

The Windows build is failing on bots: C:\cygwin\home\buildbot\WebKit\Source\WebCore\DerivedSources.cpp(345): fatal error C1083: Cannot open include file: 'JSMediaStreamTrackSourcesCallback.cpp': No such file or directory [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj] This file doesn't seem to exist anymore.

Attachments
patch (1.34 KB, patch) 2016-09-15 13:32 PDT, JF Bastien	ysuzuki: review+	Details Formatted Diff Diff
patch (1.62 KB, patch) 2016-09-15 15:15 PDT, JF Bastien	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

JF Bastien

Comment 1 2016-09-15 13:32:13 PDT

Created attachment 288989 [details] patch

Yusuke Suzuki

Comment 2 2016-09-15 13:37:17 PDT

Comment on attachment 288989 [details] patch r=me

JF Bastien

Comment 3 2016-09-15 13:42:18 PDT

I'll wait to see if the Win bot succeeds before committing manually.

JF Bastien

Comment 4 2016-09-15 15:15:04 PDT

Created attachment 289006 [details] patch JSSourceInfo.cpp is also gone.

JF Bastien

Comment 5 2016-09-16 11:35:31 PDT

Comment on attachment 289006 [details] patch Windows is green with this.

WebKit Commit Bot

Comment 6 2016-09-16 11:36:31 PDT

Comment on attachment 289006 [details] patch Rejecting attachment 289006 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 289006, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/DerivedSources.cpp Hunk #1 FAILED at 342. Hunk #2 succeeded at 420 (offset -1 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/DerivedSources.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2089335

JF Bastien

Comment 7 2016-09-27 12:16:17 PDT

This was fixed in r206034 and r206024. Closing.

Note You need to log in before you can comment on or make changes to this bug.