Bug 162017

Summary: [GTK] Ping attribute tests have been timeout since r204720
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, aperez, bugs-noreply, calvaris, cgarcia, dpino, magomez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aperez: review+

Javier Fernandez
Reported 2016-09-15 09:05:35 PDT
Need to investigate why below tests are timeout. http/tests/navigation/ping-attribute/anchor-cookie.html [ Timeout ] http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html [ Timeout ] http/tests/navigation/ping-attribute/anchor-cross-origin.html [ Timeout ] http/tests/navigation/ping-attribute/anchor-same-origin.html [ Timeout ] http/tests/navigation/ping-attribute/area-cookie.html [ Timeout ] http/tests/navigation/ping-attribute/area-cross-origin-from-https.html [ Timeout ] http/tests/navigation/ping-attribute/area-cross-origin.html [ Timeout ] http/tests/navigation/ping-attribute/area-same-origin.html [ Timeout ]
Attachments
Patch (4.25 KB, patch)
2020-06-19 02:53 PDT, Carlos Garcia Campos
aperez: review+
Miguel Gomez
Comment 1 2016-10-21 07:32:56 PDT
http/tests/navigation/ping-attribute/anchor-ping-and-follow-redirect-when-sending-ping.html is timing out as well. Updating expectations.
Alicia Boya García
Comment 2 2017-11-08 13:49:56 PST
Started crashing at some point since r224584-224585.
Alicia Boya García
Comment 3 2018-06-20 08:15:10 PDT
Failing since r232991:r232999
Alicia Boya García
Comment 4 2018-06-20 08:16:12 PDT
(In reply to Alicia Boya García from comment #3) > Failing since r232991:r232999 That only applies to http/tests/navigation/ping-attribute/area-cross-origin-from-https.html
Miguel Gomez
Comment 5 2019-08-08 06:40:02 PDT
These tests are now crashing as reported in bug 200534. Adding the crash expectation besides the existent one so we can go back to this when the crash is fixed. http/tests/navigation/ping-attribute/anchor-cookie.html [ Crash ] http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html [ Crash ] http/tests/navigation/ping-attribute/anchor-cross-origin.html [ Crash ] http/tests/navigation/ping-attribute/area-cookie.html [ Crash ] http/tests/navigation/ping-attribute/area-cross-origin.html [ Crash ] http/tests/navigation/ping-attribute/area-same-origin.html [ Crash ] http/tests/navigation/ping-attribute/anchor-ping-and-follow-redirect-when-sending-ping.html [ Crash ] http/tests/navigation/ping-attribute/area-cross-origin-from-https.html [ Crash ]
Diego Pino
Comment 6 2020-06-18 06:04:21 PDT
I think the reason why these tests are crashing is because there's no implementation of singleTapAtPoint in GTK's WKTR. https://webkit-search.igalia.com/webkit/source/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h#150 Crash-log: Thread 1 (Thread 0x7fe3e19e9e80 (LWP 227)): #0 0x00007fe3e80a97ee in WTFCrash () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #1 0x000055899ec0a679 in () #2 0x000055899ec46f30 in WTR::JSUIScriptController::singleTapAtPoint(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) () #3 0x00007fe3e7136eca in long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::JSGlobalObject*, JSC::CallFrame*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #4 0x00007fe303fff027 in () #5 0x00007fff913b2fd0 in () #6 0x00007fe3e70b396d in llint_op_call () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #7 0x0000000000000000 in () STDERR: STDERR: warning: core file may not match specified executable file. STDERR: 1 0x7fe3e80a97e9 WTFCrash STDERR: 2 0x55899ec0a679 /app/webkit/WebKitBuild/Release/bin/WebKitTestRunner(+0x17679) [0x55899ec0a679] STDERR: 3 0x55899ec46f30 /app/webkit/WebKitBuild/Release/bin/WebKitTestRunner(+0x53f30) [0x55899ec46f30] STDERR: 4 0x7fe3e7136eca long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::JSGlobalObject*, JSC::CallFrame*) STDERR: 5 0x7fe303fff027 [0x7fe303fff027] Marking tests as skip until there's an implementation of singleTapAtPoint for GTK WKTR.
Carlos Garcia Campos
Comment 7 2020-06-18 06:19:55 PDT
That's weird because singleTapAtPoint is only implemented (and I think expected to be used) by iOS.
Carlos Garcia Campos
Comment 8 2020-06-18 06:22:40 PDT
let supportsTouchEvents = "TouchEvent" in window; if (supportsTouchEvents && window.testRunner && testRunner.runUIScript) testRunner.runUIScript("(function() { uiController.singleTapAtPoint(" + x + ", " + y + ", function() { /* Do nothing */ }); })();", function() { /* Do nothing */ }); else if (window.eventSender) { I guess that's the problem, they way it's detecting if touch is supported.
Carlos Garcia Campos
Comment 9 2020-06-18 06:33:43 PDT
I think checking ontouchstart instead of TouchEvent would work because ontouchstart is only added when untimeEnabledFeatures::sharedFeatures().touchEventsEnabled() is true.
Carlos Garcia Campos
Comment 10 2020-06-19 02:38:54 PDT
*** Bug 177941 has been marked as a duplicate of this bug. ***
Carlos Garcia Campos
Comment 11 2020-06-19 02:53:48 PDT
Carlos Garcia Campos
Comment 12 2020-06-22 00:51:07 PDT
Note You need to log in before you can comment on or make changes to this bug.