Bug 162015

Summary: [Win] run-api-tests is failing.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2016-09-15 04:45:38 PDT 
This is caused by MSVC not interpreting C++ string literals with unicode characters correctly when the source file does not contain encoding information.
Comment 1 Per Arne Vollan 2016-09-15 04:52:34 PDT 
Created attachment 288951 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-15 04:55:03 PDT 
Attachment 288951 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:1:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2016-09-15 07:15:28 PDT 
Comment on attachment 288951 [details]
Patch

R=me
Comment 4 Per Arne Vollan 2016-09-15 08:46:20 PDT 
Thanks for reviewing!
Comment 5 WebKit Commit Bot 2016-09-15 08:49:07 PDT 
Comment on attachment 288951 [details]
Patch

Clearing flags on attachment: 288951

Committed r205971: <http://trac.webkit.org/changeset/205971>
Comment 6 WebKit Commit Bot 2016-09-15 08:49:10 PDT 
All reviewed patches have been landed.  Closing bug.