Bug 162015 - [Win] run-api-tests is failing.
Summary: [Win] run-api-tests is failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-15 04:45 PDT by Per Arne Vollan
Modified: 2016-09-15 08:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.15 KB, patch)
2016-09-15 04:52 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-09-15 04:45:38 PDT 
This is caused by MSVC not interpreting C++ string literals with unicode characters correctly when the source file does not contain encoding information.
Comment 1 Per Arne Vollan 2016-09-15 04:52:34 PDT 
Created attachment 288951 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-15 04:55:03 PDT 
Attachment 288951 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:1:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2016-09-15 07:15:28 PDT 
Comment on attachment 288951 [details]
Patch

R=me
Comment 4 Per Arne Vollan 2016-09-15 08:46:20 PDT 
Thanks for reviewing!
Comment 5 WebKit Commit Bot 2016-09-15 08:49:07 PDT 
Comment on attachment 288951 [details]
Patch

Clearing flags on attachment: 288951

Committed r205971: <http://trac.webkit.org/changeset/205971>
Comment 6 WebKit Commit Bot 2016-09-15 08:49:10 PDT 
All reviewed patches have been landed.  Closing bug.