Bug 161985

Summary: Pragma out undefined-var-template warnings in JSC for JSObjects that are templatized
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 162002    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch for landing none

Keith Miller
Reported 2016-09-14 13:45:41 PDT
Pragma out undefined-var-template warnings in JSC for JSObjects that are templatized
Attachments
Patch (11.29 KB, patch)
2016-09-14 14:15 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (11.62 KB, patch)
2016-09-14 14:27 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (11.83 KB, patch)
2016-09-14 14:45 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.53 KB, patch)
2016-09-14 14:59 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (16.93 KB, patch)
2016-09-14 18:53 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.02 KB, patch)
2016-09-14 19:15 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-09-14 14:15:00 PDT
Created attachment 288857 [details] Patch
Keith Miller
Comment 2 2016-09-14 14:27:21 PDT
Created attachment 288858 [details] Patch
Keith Miller
Comment 3 2016-09-14 14:45:02 PDT
Created attachment 288862 [details] Patch
JF Bastien
Comment 4 2016-09-14 14:52:18 PDT
Comment on attachment 288862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288862&action=review lgtm > Source/JavaScriptCore/ChangeLog:13 > + COMDAT will, AFAIK, pick actual specialization. If, in the COMDAT picking the zero-initialized versions would just fail early at runtime, right? If so then it'll be easy to catch if ever it starts failing.
Keith Miller
Comment 5 2016-09-14 14:54:17 PDT
Comment on attachment 288862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288862&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + COMDAT will, AFAIK, pick actual specialization. If, in the > > COMDAT picking the zero-initialized versions would just fail early at runtime, right? If so then it'll be easy to catch if ever it starts failing. Yeah, I'm pretty sure that is the case. Also, I fixed the typo in this sentence locally: "pick actual specialization" => "pick the actual specialization"
Geoffrey Garen
Comment 6 2016-09-14 14:54:37 PDT
Comment on attachment 288862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288862&action=review r=me > Source/JavaScriptCore/API/JSCallbackObject.h:157 > +#if COMPILER(CLANG) > +#if __has_warning("-Wundefined-var-template") > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wundefined-var-template" > +#endif > +#endif These macros deserve a bugzilla link to the fixme task.
Keith Miller
Comment 7 2016-09-14 14:56:04 PDT
Comment on attachment 288862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288862&action=review >> Source/JavaScriptCore/API/JSCallbackObject.h:157 >> +#endif > > These macros deserve a bugzilla link to the fixme task. Done.
Keith Miller
Comment 8 2016-09-14 14:59:06 PDT
Created attachment 288868 [details] Patch for landing
WebKit Commit Bot
Comment 9 2016-09-14 15:35:06 PDT
Comment on attachment 288868 [details] Patch for landing Clearing flags on attachment: 288868 Committed r205933: <http://trac.webkit.org/changeset/205933>
WebKit Commit Bot
Comment 10 2016-09-14 15:35:11 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 11 2016-09-14 17:13:25 PDT
Re-opened since this is blocked by bug 162002
Keith Miller
Comment 12 2016-09-14 18:53:45 PDT
Created attachment 288911 [details] Patch
Keith Miller
Comment 13 2016-09-14 19:15:24 PDT
Created attachment 288913 [details] Patch for landing
WebKit Commit Bot
Comment 14 2016-09-15 11:37:59 PDT
Comment on attachment 288913 [details] Patch for landing Clearing flags on attachment: 288913 Committed r205989: <http://trac.webkit.org/changeset/205989>
WebKit Commit Bot
Comment 15 2016-09-15 11:38:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.