Bug 161976

Summary: [MediaStream] Minor cleanup
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, adam.bergkvist, pnormand, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch. dino: review+

Eric Carlson
Reported 2016-09-14 10:15:37 PDT
- MediaStreamTrackSourcesCallback and SourceInfo aren't used, remove them - CaptureDeviceManager is used in platform, move them there - Getting the media device list doesn't need to be asynchronous
Attachments
Proposed patch. (97.75 KB, patch)
2016-09-14 10:27 PDT, Eric Carlson
no flags
Proposed patch. (97.75 KB, patch)
2016-09-14 11:00 PDT, Eric Carlson
dino: review+
Radar WebKit Bug Importer
Comment 1 2016-09-14 10:17:32 PDT
Eric Carlson
Comment 2 2016-09-14 10:27:46 PDT
Created attachment 288828 [details] Proposed patch.
Eric Carlson
Comment 3 2016-09-14 11:00:06 PDT
Created attachment 288831 [details] Proposed patch.
youenn fablet
Comment 4 2016-09-14 12:21:09 PDT
Comment on attachment 288831 [details] Proposed patch. So the major point here is to make the retrieval of devices synchronous. That seems to make sense to me. Maybe this change should be added to the ChangeLog. I'll finish the review tomorrow but this looks good to me. The win bot might want some changes to DerivedSources.cpp. View in context: https://bugs.webkit.org/attachment.cgi?id=288831&action=review > Source/WebCore/platform/mediastream/CaptureDevice.h:37 > + enum SourceKind { Audio, Video }; class enum? > Source/WebCore/platform/mediastream/CaptureDeviceManager.cpp:2 > + * Copyright (C) 2015 Apple Inc. All rights reserved. Updating the copyright? > Source/WebCore/platform/mediastream/CaptureDeviceManager.cpp:45 > +} In the header? > Source/WebCore/platform/mediastream/CaptureDeviceManager.h:27 > +#define CaptureDeviceManager_h pragma. > Source/WebCore/platform/mediastream/CaptureDeviceManager.h:34 > +#include <wtf/text/WTFString.h> Probably no need for the last two includes > Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:44 > #include "RealtimeMediaSource.h" Probably this include is not needed
Eric Carlson
Comment 5 2016-09-14 14:00:46 PDT
Alex Christensen
Comment 6 2016-09-16 09:24:21 PDT
Alex Christensen
Comment 7 2016-09-16 11:51:58 PDT
Note You need to log in before you can comment on or make changes to this bug.