Bug 161934

Summary: Treat some CSS properties as keyword properties
Product: WebKit Reporter: Daniel Bates <dbates>
Component: CSSAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2016-09-13 16:29:32 PDT
Make the following CSS properties as keyword properties: CSSPropertyColumnProgression CSSPropertyFontStretch CSSPropertyTextAlign CSSPropertyUnicodeBidi CSSPropertyWebkitColumnAxis CSSPropertyWebkitCursorVisibility CSSPropertyWebkitTextDecorationStyle CSSPropertyWebkitTextOrientation CSSPropertyWebkitTextZoom CSSPropertyWebkitTouchCallout These properties only accepts values that are keywords. Treating these properties as keyword properties is a step towards migrating from CSSParser::is{KeywordPropertyID, ValidKeywordPropertyAndValue}() to CSSParserFastPaths::is{KeywordPropertyID, ValidKeywordPropertyAndValue}(), respectively.
Attachments
Patch (15.87 KB, patch)
2016-09-13 16:33 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-09-13 16:33:07 PDT
Created attachment 288744 [details] Patch
Daniel Bates
Comment 2 2016-09-13 17:12:27 PDT
Comment on attachment 288744 [details] Patch Clearing flags on attachment: 288744 Committed r205888: <http://trac.webkit.org/changeset/205888>
Daniel Bates
Comment 3 2016-09-13 17:12:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.