Bug 161922

Summary:

MapHash should speculate on the type of its child node

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ossy, rniwa, ryanhaddad, ticaiolima, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
patch	fpizlo: review+

Saam Barati

Reported 2016-09-13 12:11:56 PDT

...

Attachments
WIP (13.56 KB, patch) 2016-09-13 19:52 PDT, Saam Barati	no flags	Details Formatted Diff Diff
patch (17.25 KB, patch) 2016-09-30 17:39 PDT, Saam Barati	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2016-09-13 19:52:20 PDT

Created attachment 288763 [details] WIP I think this is the patch, I just need to write a changelog. At some point, I want to make things fast for doubles too.

Saam Barati

Comment 2 2016-09-30 17:39:16 PDT

Created attachment 290410 [details] patch

Saam Barati

Comment 3 2016-10-03 13:52:24 PDT

landed in: https://trac.webkit.org/changeset/206746

Csaba Osztrogonác

Comment 4 2016-10-04 00:57:56 PDT

(In reply to comment #3) > landed in: > https://trac.webkit.org/changeset/206746 It made many tests assert on 32 bit Apple Mac JSC bots: - https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/3863 - https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20%28BuildAndTest%29/builds/10854

Saam Barati

Comment 5 2016-10-04 01:34:06 PDT

(In reply to comment #4) > (In reply to comment #3) > > landed in: > > https://trac.webkit.org/changeset/206746 > > It made many tests assert on 32 bit Apple Mac JSC bots: > - > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > bit%20JSC%20%28BuildAndTest%29/builds/3863 > - > https://build.webkit.org/builders/Apple%20Yosemite%2032- > bit%20JSC%20%28BuildAndTest%29/builds/10854 Will fix. Thanks.