Bug 16187
| Summary: | MatchStack should allocate frames in chunks and only free them in ~MatchStack | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | barraclough |
| Priority: | P2 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| Bug Depends on: | |||
| Bug Blocks: | 16186 | ||
Eric Seidel (no email)
MatchStack should allocate frames in chunks and only free them in ~MatchStack
Currently MatchStack will allocate a new frame each time you recurse once you've gone past FRAMES_ON_STACK frames.
Instead, MatchStack should allocate frames in chunks (to avoid individual mallocs) and hold onto those chunks until ~MatchStack() is called.
This would be a win for any regexp which uses more than FRAMES_ON_STACK frames in more than one place in the regexp.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gavin Barraclough
This is a proposed optimization for PCRE; we no longer use PCRE.