Bug 161857

Summary: [DFG][FTL] Add ArithTan
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, ryanhaddad, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2016-09-11 23:49:03 PDT
[DFG][FTL] Add ArithTan
Attachments
Patch (29.96 KB, patch)
2016-09-11 23:55 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.
Yusuke Suzuki
Comment 1 2016-09-11 23:55:40 PDT
Created attachment 288556 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-12 15:03:18 PDT
Comment on attachment 288556 [details] Patch Clearing flags on attachment: 288556 Committed r205828: <http://trac.webkit.org/changeset/205828>
WebKit Commit Bot
Comment 3 2016-09-12 15:03:22 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 4 2016-09-12 15:56:32 PDT
stress/ftl-arithtan.js appears to be failing on Yosemite Release JSC tests (other bots are behind, so this may eventually fail on other configurations too) https://build.webkit.org/builders/Apple%20Yosemite%20Release%20JSC%20(Tests)/builds/14218/steps/jscore-test/logs/stdio
Yusuke Suzuki
Comment 5 2016-09-12 16:08:13 PDT
(In reply to comment #4) > stress/ftl-arithtan.js appears to be failing on Yosemite Release JSC tests > (other bots are behind, so this may eventually fail on other configurations > too) > > https://build.webkit.org/builders/Apple%20Yosemite%20Release%20JSC%20(Tests)/ > builds/14218/steps/jscore-test/logs/stdio Ah, ok. This is due to different results produced from different libms. I created this test case on Linux box, and the result seems slightly different from libm on OS X. (-1.687173625802563 v.s. -1.6871736258025631). I'll fix this test soon.
Yusuke Suzuki
Comment 6 2016-09-12 16:14:05 PDT
Committed r205837: <http://trac.webkit.org/changeset/205837>