Summary: | Apple.com keynote does not display media controls | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
Component: | Media | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, commit-queue, jer.noble, thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Wenson Hsieh
2016-09-09 19:33:36 PDT
Created attachment 288478 [details]
Patch
Comment on attachment 288478 [details]
Patch
It's not totally clear to me why we'd want the two heuristics to be different (why we wouldn't loosen both), but this seems like a safer fix for now (guessing it is about risk), I guess. Can you file a follow up bug about maybe reunifying in the future, or is there a good reason we wouldn't want to do that?
(In reply to comment #3) > Comment on attachment 288478 [details] > Patch > > It's not totally clear to me why we'd want the two heuristics to be > different (why we wouldn't loosen both), but this seems like a safer fix for > now (guessing it is about risk), I guess. Can you file a follow up bug about > maybe reunifying in the future, or is there a good reason we wouldn't want > to do that? It's primarily about mitigating risk. For other reasons included in the radar though, I think there's some argument to be made for keeping the heuristic slightly different in the two cases. Comment on attachment 288478 [details] Patch Clearing flags on attachment: 288478 Committed r205784: <http://trac.webkit.org/changeset/205784> All reviewed patches have been landed. Closing bug. |