Bug 161833 - Apple.com keynote does not display media controls
Summary: Apple.com keynote does not display media controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-09 19:33 PDT by Wenson Hsieh
Modified: 2016-09-10 01:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.10 KB, patch)
2016-09-09 19:47 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-09-09 19:33:36 PDT 
Apple.com keynote does not display media controls
Comment 1 Wenson Hsieh 2016-09-09 19:34:00 PDT 
<rdar://problem/28230123>
Comment 2 Wenson Hsieh 2016-09-09 19:47:48 PDT 
Created attachment 288478 [details]
Patch
Comment 3 Tim Horton 2016-09-09 23:44:00 PDT 
Comment on attachment 288478 [details]
Patch

It's not totally clear to me why we'd want the two heuristics to be different (why we wouldn't loosen both), but this seems like a safer fix for now (guessing it is about risk), I guess. Can you file a follow up bug about maybe reunifying in the future, or is there a good reason we wouldn't want to do that?
Comment 4 Wenson Hsieh 2016-09-10 00:58:48 PDT 
(In reply to comment #3)
> Comment on attachment 288478 [details]
> Patch
> 
> It's not totally clear to me why we'd want the two heuristics to be
> different (why we wouldn't loosen both), but this seems like a safer fix for
> now (guessing it is about risk), I guess. Can you file a follow up bug about
> maybe reunifying in the future, or is there a good reason we wouldn't want
> to do that?

It's primarily about mitigating risk. For other reasons included in the radar though, I think there's some argument to be made for keeping the heuristic slightly different in the two cases.
Comment 5 WebKit Commit Bot 2016-09-10 01:21:13 PDT 
Comment on attachment 288478 [details]
Patch

Clearing flags on attachment: 288478

Committed r205784: <http://trac.webkit.org/changeset/205784>
Comment 6 WebKit Commit Bot 2016-09-10 01:21:17 PDT 
All reviewed patches have been landed.  Closing bug.