Summary: | Text replacement candidates don't always overwrite the entire original string | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, commit-queue, enrica, rniwa, simon.fraser, wenson_hsieh | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2016-09-08 17:38:18 PDT
Created attachment 288369 [details]
Patch
Comment on attachment 288369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288369&action=review > Source/WebCore/ChangeLog:3 > + WebKit not always respecting range of candidates This title is not very helpful. Which candidates? "the range"? > Source/WebCore/editing/Editor.cpp:3620 > +void Editor::selectTextCheckingResult(TextCheckingResult result) Pass by reference? It's not tiny. (In reply to comment #2) > Comment on attachment 288369 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=288369&action=review > > > Source/WebCore/ChangeLog:3 > > + WebKit not always respecting range of candidates > > This title is not very helpful. Which candidates? "the range"? Heh, sure, will fix. > > Source/WebCore/editing/Editor.cpp:3620 > > +void Editor::selectTextCheckingResult(TextCheckingResult result) > > Pass by reference? It's not tiny. Sure! Created attachment 288432 [details]
Patch
Comment on attachment 288432 [details] Patch Clearing flags on attachment: 288432 Committed r205765: <http://trac.webkit.org/changeset/205765> All reviewed patches have been landed. Closing bug. |