Summary: | REGRESSION: [mac-wk2] LayoutTest inspector/debugger/breakpoint-columns.html is a flaky failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, mark.lam, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2016-09-08 17:07:29 PDT
First failure on the dashboard was ~r204952, but the test has been quite flaky since ~r204896 on 8/24/18 > +ERROR: Received a command response without a corresponding callback or promise. [object Object]
Seems concerning. I don't think we've made any changes here (yet), so I wonder if this is actually a regression with `Map`? I know some changes just landed there (both GC storage, and the implementation).
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/205747 The Flakiness Dashboard shows this test as all green for an entire month: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=inspector%2Fdebugger%2Fbreakpoint-columns.html I suggest unskipping this. Given the bizarness of the error message seen previously, one I've _never_ seen while running tests or the Inspector itself, I think this was a lower level issue that likely got resolved. Created attachment 298628 [details]
[PATCH] Proposed Fix
Comment on attachment 298628 [details]
[PATCH] Proposed Fix
rs=me
Comment on attachment 298628 [details] [PATCH] Proposed Fix Clearing flags on attachment: 298628 Committed r210620: <http://trac.webkit.org/changeset/210620> All reviewed patches have been landed. Closing bug. |