Bug 161774 – REGRESSION: [mac-wk2] LayoutTest inspector/debugger/breakpoint-columns.html is a flaky failure

• Component: Web Inspector
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest inspector/debugger/breakpoint-columns.html is a flaky failure

https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20(Tests)/builds/14880

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreakpoint-columns.html

--- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/debugger/breakpoint-columns-expected.txt
+++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/debugger/breakpoint-columns-actual.txt
@@ -10,6 +10,7 @@
 CONSOLE MESSAGE: line 12: column test 5
 Testing that breakpoints can be set at various line / column combinations.
 
+ERROR: Received a command response without a corresponding callback or promise. [object Object] 
 Hit breakpoint at line: 0, column: 79
 Hit breakpoint at line: 6, column: 21
 Hit breakpoint at line: 15, column: 8

[Radar WebKit Bug Importer]

<rdar://problem/28217256>

[Ryan Haddad]

First failure on the dashboard was ~r204952, but the test has been quite flaky since ~r204896 on 8/24/18

[Joseph Pecoraro]

> +ERROR: Received a command response without a corresponding callback or promise. [object Object] 

Seems concerning. I don't think we've made any changes here (yet), so I wonder if this is actually a regression with `Map`? I know some changes just landed there (both GC storage, and the implementation).

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/205747

[Joseph Pecoraro]

The Flakiness Dashboard shows this test as all green for an entire month:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=inspector%2Fdebugger%2Fbreakpoint-columns.html

I suggest unskipping this. Given the bizarness of the error message seen previously, one I've _never_ seen while running tests or the Inspector itself, I think this was a lower level issue that likely got resolved.

[Joseph Pecoraro]

Created attachment 298628 [details]
[PATCH] Proposed Fix

[Mark Lam]

Comment on attachment 298628 [details]
[PATCH] Proposed Fix

rs=me

[WebKit Commit Bot]

Comment on attachment 298628 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 298628

Committed r210620: <http://trac.webkit.org/changeset/210620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.