Bug 161771

Summary: Enhance Network logging
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit2Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, japhet, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Keith Rollin 2016-09-08 16:56:13 PDT 
The initial logging used to track progress through the resource-downloading operation is a bit scattered. It would be better for it to conform to some sort of standard. By doing this, the logging can be more easily tracked and parsed (possibly by tools that try to extract important information from the logging. 

Change the logging to generally follow the format:

<this> - <class>::<method>: <message> (<data>)

<this>: Helps track activity for one particular instances, such as the downloading of one particular resource.
<class>::<method>: Helps identify what stage of the operation we are in.
<message>: Some arbitrary message, useful if a single method logs multiple times. Optional.
<data>: Handy data to help us understand what's going on. Optional.

For example:

0x110bf5000 - WebLoaderStrategy::scheduleLoad: Resource will be scheduled with the NetworkProcess (priority = 2, pageID = 6, frameID = 1, WebResourceLoader = 0x113858288)

0x113858288 - WebResourceLoader::didReceiveData: (size = 16384)

0x113858288 - WebResourceLoader::didFinishResourceLoad
Comment 1 Keith Rollin 2016-09-09 11:00:33 PDT 
Created attachment 288415 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-12 12:01:37 PDT 
Comment on attachment 288415 [details]
Patch

Clearing flags on attachment: 288415

Committed r205817: <http://trac.webkit.org/changeset/205817>
Comment 3 WebKit Commit Bot 2016-09-12 12:01:41 PDT 
All reviewed patches have been landed.  Closing bug.