Bug 161766

Summary: HTMLObjectElement.hspace / vspace attributes should be unsigned
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/#HTMLObjectElement-partial
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2
none
Patch none

Description Chris Dumez 2016-09-08 15:52:57 PDT
HTMLObjectElement.hspace / vspace attributes should be unsigned:
- https://html.spec.whatwg.org/#HTMLObjectElement-partial

Firefox agrees with the specification but those are signed in WebKit.
Comment 1 Chris Dumez 2016-09-08 18:59:58 PDT
Created attachment 288374 [details]
Patch
Comment 2 Build Bot 2016-09-08 20:36:17 PDT
Comment on attachment 288374 [details]
Patch

Attachment 288374 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2038384

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 3 Build Bot 2016-09-08 20:36:22 PDT
Created attachment 288383 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 4 Chris Dumez 2016-09-08 20:50:36 PDT
Created attachment 288385 [details]
Patch
Comment 5 Chris Dumez 2016-09-08 20:51:15 PDT
Comment on attachment 288385 [details]
Patch

Clearing flags on attachment: 288385

Committed r205691: <http://trac.webkit.org/changeset/205691>
Comment 6 Chris Dumez 2016-09-08 20:51:20 PDT
All reviewed patches have been landed.  Closing bug.