Bug 161766 - HTMLObjectElement.hspace / vspace attributes should be unsigned
Summary: HTMLObjectElement.hspace / vspace attributes should be unsigned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/#HTMLObj...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-09-08 15:52 PDT by Chris Dumez
Modified: 2016-09-08 20:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.96 KB, patch)
2016-09-08 18:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 (11.29 MB, application/zip)
2016-09-08 20:36 PDT, Build Bot 		no flags Details
Patch (15.55 KB, patch)
2016-09-08 20:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-08 15:52:57 PDT 
HTMLObjectElement.hspace / vspace attributes should be unsigned:
- https://html.spec.whatwg.org/#HTMLObjectElement-partial

Firefox agrees with the specification but those are signed in WebKit.
Comment 1 Chris Dumez 2016-09-08 18:59:58 PDT 
Created attachment 288374 [details]
Patch
Comment 2 Build Bot 2016-09-08 20:36:17 PDT 
Comment on attachment 288374 [details]
Patch

Attachment 288374 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2038384

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 3 Build Bot 2016-09-08 20:36:22 PDT 
Created attachment 288383 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 4 Chris Dumez 2016-09-08 20:50:36 PDT 
Created attachment 288385 [details]
Patch
Comment 5 Chris Dumez 2016-09-08 20:51:15 PDT 
Comment on attachment 288385 [details]
Patch

Clearing flags on attachment: 288385

Committed r205691: <http://trac.webkit.org/changeset/205691>
Comment 6 Chris Dumez 2016-09-08 20:51:20 PDT 
All reviewed patches have been landed.  Closing bug.