Bug 161765

Summary: Web Inspector: TimelineDataGridNode should refresh when graph column is resized
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix none

Description Matt Baker 2016-09-08 15:38:32 PDT
Summary:
TimelineDataGridNode should refresh when graph column is resized. Currently graphs only refresh when the entire view tree is being updated due to a window resize or sidebar expand/collapse.

Now that OverviewTimelineView has two columns (the Name column was added when the navigation sidebar was removed), it's possible for the graph column to be resized without the nodes ever being refreshed.

Steps to Reproduce:
1. Record a timeline
2. Show the overview
3. Change width of the graph column using the column resizer between the Name and Graph columns
  => Record bars aren't recombined as the column size changed
Comment 1 Radar WebKit Bug Importer 2016-09-08 15:38:52 PDT
<rdar://problem/28215674>
Comment 2 Matt Baker 2016-09-08 15:51:43 PDT
Created attachment 288344 [details]
[Patch] Proposed Fix
Comment 3 BJ Burg 2016-09-08 16:01:09 PDT
Comment on attachment 288344 [details]
[Patch] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2016-09-08 16:23:27 PDT
Comment on attachment 288344 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 288344

Committed r205676: <http://trac.webkit.org/changeset/205676>
Comment 5 WebKit Commit Bot 2016-09-08 16:23:31 PDT
All reviewed patches have been landed.  Closing bug.