Bug 161757

Summary: Add support for HTMLIframeElement.allowFullscreen attribute
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, gyuyoung.kim, jer.noble, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/#dom-iframe-allowfullscreen
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2
none
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2
none
Patch none

Description Chris Dumez 2016-09-08 13:48:49 PDT 
Add support for HTMLIframeElement.allowFullscreen attribute:
- https://html.spec.whatwg.org/#dom-iframe-allowfullscreen

Firefox and Chrome already support it, unprefixed.
Comment 1 Chris Dumez 2016-09-08 14:35:24 PDT 
Created attachment 288322 [details]
Patch
Comment 2 Build Bot 2016-09-08 15:33:19 PDT 
Comment on attachment 288322 [details]
Patch

Attachment 288322 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2036772

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 3 Build Bot 2016-09-08 15:33:24 PDT 
Created attachment 288339 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 4 Chris Dumez 2016-09-08 15:39:27 PDT 
Created attachment 288341 [details]
Patch
Comment 5 Build Bot 2016-09-08 16:52:15 PDT 
Comment on attachment 288341 [details]
Patch

Attachment 288341 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2037204

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 6 Build Bot 2016-09-08 16:52:20 PDT 
Created attachment 288358 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 7 Chris Dumez 2016-09-08 16:54:14 PDT 
Created attachment 288362 [details]
Patch
Comment 8 WebKit Commit Bot 2016-09-08 18:55:53 PDT 
Comment on attachment 288362 [details]
Patch

Clearing flags on attachment: 288362

Committed r205686: <http://trac.webkit.org/changeset/205686>
Comment 9 WebKit Commit Bot 2016-09-08 18:56:00 PDT 
All reviewed patches have been landed.  Closing bug.