Bug 161757 - Add support for HTMLIframeElement.allowFullscreen attribute
Summary: Add support for HTMLIframeElement.allowFullscreen attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/#dom-ifr...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-09-08 13:48 PDT by Chris Dumez
Modified: 2016-09-08 18:56 PDT (History)
11 users (show)

See Also:

Attachments
Patch (16.56 KB, patch)
2016-09-08 14:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (16.36 MB, application/zip)
2016-09-08 15:33 PDT, Build Bot 		no flags Details
Patch (16.54 KB, patch)
2016-09-08 15:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2 (7.60 MB, application/zip)
2016-09-08 16:52 PDT, Build Bot 		no flags Details
Patch (28.35 KB, patch)
2016-09-08 16:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-08 13:48:49 PDT 
Add support for HTMLIframeElement.allowFullscreen attribute:
- https://html.spec.whatwg.org/#dom-iframe-allowfullscreen

Firefox and Chrome already support it, unprefixed.
Comment 1 Chris Dumez 2016-09-08 14:35:24 PDT 
Created attachment 288322 [details]
Patch
Comment 2 Build Bot 2016-09-08 15:33:19 PDT 
Comment on attachment 288322 [details]
Patch

Attachment 288322 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2036772

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 3 Build Bot 2016-09-08 15:33:24 PDT 
Created attachment 288339 [details]
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 4 Chris Dumez 2016-09-08 15:39:27 PDT 
Created attachment 288341 [details]
Patch
Comment 5 Build Bot 2016-09-08 16:52:15 PDT 
Comment on attachment 288341 [details]
Patch

Attachment 288341 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2037204

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 6 Build Bot 2016-09-08 16:52:20 PDT 
Created attachment 288358 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 7 Chris Dumez 2016-09-08 16:54:14 PDT 
Created attachment 288362 [details]
Patch
Comment 8 WebKit Commit Bot 2016-09-08 18:55:53 PDT 
Comment on attachment 288362 [details]
Patch

Clearing flags on attachment: 288362

Committed r205686: <http://trac.webkit.org/changeset/205686>
Comment 9 WebKit Commit Bot 2016-09-08 18:56:00 PDT 
All reviewed patches have been landed.  Closing bug.