Bug 161756

Summary:

REGRESSION (r205569?): 32-bit JSC test timeout: stress/rest-parameter-many-arguments.js.dfg-maximal-flush-validate-no-cjit

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, mark.lam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=161498

Attachments:

Description	Flags
proposed patch.	saam: review+

Description Ryan Haddad 2016-09-08 13:43:15 PDT

32-bit JSC test timeout: stress/rest-parameter-many-arguments.js.dfg-maximal-flush-validate-no-cjit

https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/3632

Comment 1 Ryan Haddad 2016-09-08 13:43:40 PDT

This regressed between r205568 and r205574

Comment 2 Ryan Haddad 2016-09-08 13:44:59 PDT

Possibly https://trac.webkit.org/changeset/205569

Comment 3 Mark Lam 2016-09-08 14:21:01 PDT

Running locally, the test appears to finish just fine.

Comment 4 Mark Lam 2016-09-08 14:53:22 PDT

Looks like the bot is just too slow.  Running the full suite locally on MacPro with the test harness, I don't see the time out at all.  I'll see if I can skip this test configuration for 32-bit x86.

Comment 5 Mark Lam 2016-09-08 15:00:54 PDT

Created attachment 288333 [details]
proposed patch.

Comment 6 Mark Lam 2016-09-08 15:03:31 PDT

Thanks for the review.  Landed in r205664: <http://trac.webkit.org/r205664>.