Bug 161752

Summary: Make the HeapVerifier useful again
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 169443    
Bug Blocks:    
Attachments:
Description Flags
work in progress: has lots of debugging code that needs to be cleaned up.
none
work in progress 2
none
proposed patch.
fpizlo: review+
patch for landing.
none
patch for landing: rebased to ToT again.
none
Patch for landing: with fix for the Windows build. none

Filip Pizlo
Reported 2016-09-08 13:14:54 PDT
...
Attachments
work in progress: has lots of debugging code that needs to be cleaned up. (73.64 KB, patch)
2017-02-16 14:54 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
work in progress 2 (79.92 KB, patch)
2017-02-17 09:28 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (36.45 KB, patch)
2017-03-10 15:00 PST, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
patch for landing. (36.64 KB, patch)
2017-03-13 14:10 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for landing: rebased to ToT again. (36.64 KB, patch)
2017-03-13 14:18 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Patch for landing: with fix for the Windows build. (36.64 KB, patch)
2017-03-13 16:38 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-02-16 14:54:50 PST
Created attachment 301831 [details] work in progress: has lots of debugging code that needs to be cleaned up.
Filip Pizlo
Comment 2 2017-02-16 14:57:30 PST
Comment on attachment 301831 [details] work in progress: has lots of debugging code that needs to be cleaned up. View in context: https://bugs.webkit.org/attachment.cgi?id=301831&action=review > Source/JavaScriptCore/heap/MarkedBlockInlines.h:222 > + if (vm.heap.verifier()) > + vm.heap.verifier()->addSweptCell(cell); > + } This doesn't catch all cases of swept cells.
Mark Lam
Comment 3 2017-02-17 09:28:43 PST
Created attachment 301943 [details] work in progress 2
Mark Lam
Comment 4 2017-03-10 15:00:37 PST
Created attachment 304082 [details] proposed patch. Let's try this on the EWS first.
Filip Pizlo
Comment 5 2017-03-13 10:50:33 PDT
Comment on attachment 304082 [details] proposed patch. LGTM. Seems like you might have builds to fix.
Mark Lam
Comment 6 2017-03-13 14:10:58 PDT
Created attachment 304298 [details] patch for landing. Thanks for the review.
Mark Lam
Comment 7 2017-03-13 14:18:23 PDT
Created attachment 304300 [details] patch for landing: rebased to ToT again.
Mark Lam
Comment 8 2017-03-13 16:38:27 PDT
Created attachment 304322 [details] Patch for landing: with fix for the Windows build. The Windows EWS actually found a bug (now fixed).
Mark Lam
Comment 9 2017-03-13 17:40:02 PDT
Landed in r213883: <http://trac.webkit.org/r213883>.
Mark Lam
Comment 10 2017-03-15 12:03:52 PDT
<rdar://problem/30358206>
Note You need to log in before you can comment on or make changes to this bug.