Bug 161711

Summary:

URLParser should handle URLs with empty authority

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	beidson: review+

Alex Christensen

Reported 2016-09-07 13:28:05 PDT

URLParser should handle URLs with empty authority

Attachments
Patch (6.75 KB, patch) 2016-09-07 13:29 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (7.04 KB, patch) 2016-09-07 18:48 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (7.10 KB, patch) 2016-09-08 10:30 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (7.04 KB, patch) 2016-09-08 11:31 PDT, Alex Christensen	beidson: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-09-07 13:29:53 PDT

Created attachment 288180 [details] Patch

Alex Christensen

Comment 2 2016-09-07 18:48:56 PDT

Created attachment 288221 [details] Patch

Alex Christensen

Comment 3 2016-09-08 10:30:53 PDT

Created attachment 288275 [details] Patch

Alex Christensen

Comment 4 2016-09-08 11:31:41 PDT

Created attachment 288290 [details] Patch

Alex Christensen

Comment 5 2016-09-08 11:33:00 PDT

Comment on attachment 288290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288290&action=review > Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:371 > - {"https", "", "", "", 0, "", "", "", "https://"}, > + {"", "", "", "", 0, "", "", "", ""}, Note: This changes to match the standard and Anne's comment in https://bugs.webkit.org/show_bug.cgi?id=161364 I was skeptical in that patch, but this patch helps me to see he's right.

Brady Eidson

Comment 6 2016-09-08 15:13:30 PDT

Comment on attachment 288290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288290&action=review > Source/WebCore/platform/URLParser.cpp:975 > void URLParser::parseAuthority(StringView::CodePoints::Iterator& iterator, const StringView::CodePoints::Iterator& end) This has already come up before, but this method signature stinks :(

Alex Christensen

Comment 7 2016-09-08 15:17:14 PDT

r205667

Note You need to log in before you can comment on or make changes to this bug.