| Summary: | URLParser should handle URLs with empty authority | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | ||||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2016-09-07 13:28:05 PDT
Created attachment 288180 [details]
Patch
Created attachment 288221 [details]
Patch
Created attachment 288275 [details]
Patch
Created attachment 288290 [details]
Patch
Comment on attachment 288290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288290&action=review > Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:371 > - {"https", "", "", "", 0, "", "", "", "https://"}, > + {"", "", "", "", 0, "", "", "", ""}, Note: This changes to match the standard and Anne's comment in https://bugs.webkit.org/show_bug.cgi?id=161364 I was skeptical in that patch, but this patch helps me to see he's right. Comment on attachment 288290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288290&action=review > Source/WebCore/platform/URLParser.cpp:975 > void URLParser::parseAuthority(StringView::CodePoints::Iterator& iterator, const StringView::CodePoints::Iterator& end) This has already come up before, but this method signature stinks :( |