Bug 161668

Summary: REGRESSION(r205521): broke API tests (Requested by alexchristensen on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ryanhaddad, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161655, 161657, 161667    
Attachments:
Description Flags
ROLLOUT of r205521
none
Patch none

WebKit Commit Bot
Reported 2016-09-06 18:41:15 PDT
http://trac.webkit.org/changeset/205521 broke the build: broke API tests (Requested by alexchristensen on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r205521 (10.61 KB, patch)
2016-09-06 18:41 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
Patch (10.12 KB, patch)
2016-09-07 17:30 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2016-09-06 18:41:53 PDT
Created attachment 288082 [details] ROLLOUT of r205521 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Commit Bot
Comment 2 2016-09-06 18:45:10 PDT
Comment on attachment 288082 [details] ROLLOUT of r205521 Clearing flags on attachment: 288082 Committed r205533: <http://trac.webkit.org/changeset/205533>
WebKit Commit Bot
Comment 3 2016-09-06 18:45:13 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 4 2016-09-07 17:30:33 PDT
Reopening to attach new patch.
Alex Christensen
Comment 5 2016-09-07 17:30:34 PDT
Created attachment 288211 [details] Patch
Alex Christensen
Comment 6 2016-09-07 18:36:47 PDT
http://trac.webkit.org/changeset/205580
Alex Christensen
Comment 7 2016-09-07 21:13:59 PDT
http://trac.webkit.org/changeset/205582 covers up a bug that I can only reproduce on the bots (bot190) but there's something fishy going on. It's only when there are no logging calls in URLParser. Maybe using uninitialized memory somewhere.
Ryan Haddad
Comment 8 2016-09-07 22:47:02 PDT
(In reply to comment #7) > http://trac.webkit.org/changeset/205582 covers up a bug that I can only > reproduce on the bots (bot190) but there's something fishy going on. It's > only when there are no logging calls in URLParser. Maybe using > uninitialized memory somewhere. The tests still seem to be failing on the bots with this change https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/9549/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/9263
Alex Christensen
Comment 9 2016-09-07 23:02:14 PDT
Rolled everything out again in r205584
Alex Christensen
Comment 10 2016-09-08 10:25:59 PDT
Aaaaaaand back in in http://trac.webkit.org/changeset/205650
Note You need to log in before you can comment on or make changes to this bug.