Bug 161665

Summary:

Rename Key to CryptoKey

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, cdumez, commit-queue, esprehn+autocc, jiewen_tan, kondapallykalyan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

160877

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Patch	none

Jiewen Tan

Reported 2016-09-06 17:59:31 PDT

Rename Key to CryptoKey.

Attachments
Patch (16.31 KB, patch) 2016-09-06 18:09 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.35 MB, application/zip) 2016-09-06 18:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (1.49 MB, application/zip) 2016-09-06 19:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-yosemite (985.50 KB, application/zip) 2016-09-06 19:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (7.85 MB, application/zip) 2016-09-06 19:20 PDT, Build Bot	no flags	Details
Patch (21.75 KB, patch) 2016-09-08 11:14 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Patch (21.83 KB, patch) 2016-09-08 13:54 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.02 MB, application/zip) 2016-09-08 14:56 PDT, Build Bot	no flags	Details
Patch (23.41 KB, patch) 2016-09-08 16:52 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Jiewen Tan

Comment 1 2016-09-06 18:00:04 PDT

<rdar://problem/28083391>

Jiewen Tan

Comment 2 2016-09-06 18:09:59 PDT

Created attachment 288080 [details] Patch

Build Bot

Comment 3 2016-09-06 18:55:08 PDT

Comment on attachment 288080 [details] Patch Attachment 288080 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2021146 New failing tests: imported/w3c/WebCryptoAPI/idlharness.html js/dom/global-constructors-attributes.html

Build Bot

Comment 4 2016-09-06 18:55:12 PDT

Created attachment 288083 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-09-06 19:09:39 PDT

Comment on attachment 288080 [details] Patch Attachment 288080 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2021183 New failing tests: imported/w3c/WebCryptoAPI/idlharness.html

Build Bot

Comment 6 2016-09-06 19:09:44 PDT

Created attachment 288087 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-09-06 19:14:59 PDT

Comment on attachment 288080 [details] Patch Attachment 288080 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2021232 New failing tests: imported/w3c/WebCryptoAPI/idlharness.html

Build Bot

Comment 8 2016-09-06 19:15:04 PDT

Created attachment 288088 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Chris Dumez

Comment 9 2016-09-06 19:16:47 PDT

Comment on attachment 288080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288080&action=review > Source/WebCore/ChangeLog:8 > + Please provide a link to the spec for CryptoKey.

Build Bot

Comment 10 2016-09-06 19:20:18 PDT

Comment on attachment 288080 [details] Patch Attachment 288080 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2021195 New failing tests: imported/w3c/WebCryptoAPI/idlharness.html

Build Bot

Comment 11 2016-09-06 19:20:23 PDT

Created attachment 288089 [details] Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5

Jiewen Tan

Comment 12 2016-09-08 11:14:16 PDT

Created attachment 288285 [details] Patch

Jiewen Tan

Comment 13 2016-09-08 13:54:12 PDT

Created attachment 288316 [details] Patch

Build Bot

Comment 14 2016-09-08 14:56:51 PDT

Comment on attachment 288316 [details] Patch Attachment 288316 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2036514 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 15 2016-09-08 14:56:56 PDT

Created attachment 288331 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Jiewen Tan

Comment 16 2016-09-08 16:52:34 PDT

Created attachment 288359 [details] Patch

Brent Fulgham

Comment 17 2016-09-08 18:30:31 PDT

Comment on attachment 288359 [details] Patch r=me

Chris Dumez

Comment 18 2016-09-08 18:34:03 PDT

Comment on attachment 288359 [details] Patch lgtm2

WebKit Commit Bot

Comment 19 2016-09-09 11:40:49 PDT

Comment on attachment 288359 [details] Patch Clearing flags on attachment: 288359 Committed r205755: <http://trac.webkit.org/changeset/205755>

WebKit Commit Bot

Comment 20 2016-09-09 11:40:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.