Summary: | Web Inspector: step-into `console.log(o)` should not step through inspector javascript | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bburg, buildbot, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, rniwa, saam, timothy, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-09-06 17:00:33 PDT
This seems like a special case of script black boxing. Created attachment 291409 [details]
[PATCH] Proposed Fix
Comment on attachment 291409 [details] [PATCH] Proposed Fix Attachment 291409 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2273212 New failing tests: inspector/debugger/breakpoint-syntax-error-top-level.html inspector/debugger/setPauseOnExceptions-uncaught.html inspector/debugger/command-line-api-exception.html inspector/dom-debugger/node-removed.html inspector/debugger/regress-133182.html inspector/debugger/setPauseOnExceptions-all.html Created attachment 291414 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Investigating test failures. (In reply to comment #6) > Investigating test failures. The issue is that SourceID could be 0, and the default HashSet doesn't allow 0. I'm making the following change to allow Map/Set with a SourceID of 0: - HashMap<SourceID, DebuggerParseData> m_parseDataMap; - HashSet<SourceID> m_blacklistedScripts; + HashMap<SourceID, DebuggerParseData, WTF::IntHash<SourceID>, WTF::UnsignedWithZeroKeyHashTraits<SourceID>> m_parseDataMap; + HashSet<SourceID, WTF::IntHash<SourceID>, WTF::UnsignedWithZeroKeyHashTraits<SourceID>> m_blacklistedScripts; Comment on attachment 291409 [details] [PATCH] Proposed Fix Attachment 291409 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2273307 New failing tests: inspector/debugger/breakpoint-syntax-error-top-level.html inspector/debugger/setPauseOnExceptions-uncaught.html inspector/debugger/command-line-api-exception.html inspector/dom-debugger/node-removed.html inspector/debugger/regress-133182.html inspector/debugger/setPauseOnExceptions-all.html Created attachment 291421 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 291423 [details]
[PATCH] For Landing
Comment on attachment 291423 [details] [PATCH] For Landing View in context: https://bugs.webkit.org/attachment.cgi?id=291423&action=review > Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h:161 > + HashSet<JSC::SourceID> m_blacklistedScripts; Err, this should be removed. Created attachment 291426 [details]
[PATCH] For Landing
Comment on attachment 291409 [details] [PATCH] Proposed Fix Attachment 291409 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2273308 New failing tests: inspector/debugger/breakpoint-syntax-error-top-level.html inspector/debugger/pause-reason.html inspector/debugger/setPauseOnExceptions-uncaught.html inspector/debugger/command-line-api-exception.html inspector/dom-debugger/node-removed.html inspector/debugger/pause-on-assert.html inspector/debugger/csp-exceptions.html inspector/debugger/regress-133182.html inspector/debugger/setPauseOnExceptions-all.html Created attachment 291428 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291426 [details] [PATCH] For Landing Clearing flags on attachment: 291426 Committed r207267: <http://trac.webkit.org/changeset/207267> |