Bug 161644

Summary: Add support for input.minLength / textArea.minLength
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, rniwa, sam, webkit
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=162727
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-09-06 14:13:23 PDT
Add support for input.minLength / textArea.minLength: - https://html.spec.whatwg.org/#dom-input-minlength - https://html.spec.whatwg.org/#dom-textarea-minlength Chrome implements this, Firefox does not yet.
Attachments
Patch (72.63 KB, patch)
2016-09-06 14:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (73.32 KB, patch)
2016-09-06 14:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (74.61 KB, patch)
2016-09-06 15:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (78.88 KB, patch)
2016-09-06 16:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (78.88 KB, patch)
2016-09-06 16:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-09-06 14:39:45 PDT
Created attachment 288046 [details] Patch
Chris Dumez
Comment 2 2016-09-06 14:50:48 PDT
Created attachment 288048 [details] Patch
Chris Dumez
Comment 3 2016-09-06 15:40:06 PDT
Created attachment 288054 [details] Patch
Darin Adler
Comment 4 2016-09-06 15:46:39 PDT
Comment on attachment 288054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288054&action=review > Source/WebCore/html/HTMLInputElement.cpp:297 > + // Return false for the default value or a value set by a script even if > + // it is longer than maxLength. Comment here mentions maxLength. That must be wrong. > Source/WebCore/html/HTMLInputElement.h:408 > + bool tooShort(const String&, NeedsToCheckDirtyFlag) const; Seems like this should take a StringView, not a String.
Chris Dumez
Comment 5 2016-09-06 16:16:38 PDT
Created attachment 288062 [details] Patch
Chris Dumez
Comment 6 2016-09-06 16:29:13 PDT
Created attachment 288065 [details] Patch
WebKit Commit Bot
Comment 7 2016-09-06 17:02:11 PDT
Comment on attachment 288065 [details] Patch Clearing flags on attachment: 288065 Committed r205524: <http://trac.webkit.org/changeset/205524>
WebKit Commit Bot
Comment 8 2016-09-06 17:02:16 PDT
All reviewed patches have been landed. Closing bug.
Chris Rebert
Comment 9 2016-09-29 00:20:59 PDT
The "Assigning non-numeric to minlength sets minlength to 0" test in http://w3c-test.org/html/semantics/forms/the-input-element/minlength.html is still failing.
Chris Rebert
Comment 10 2016-09-29 00:22:33 PDT
*** Bug 149832 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 11 2016-09-29 08:58:41 PDT
(In reply to comment #9) > The "Assigning non-numeric to minlength sets minlength to 0" test in > http://w3c-test.org/html/semantics/forms/the-input-element/minlength.html > is still failing. Thanks for letting me know. I'll fix this soon: https://bugs.webkit.org/show_bug.cgi?id=162727
Ryosuke Niwa
Comment 12 2016-09-29 09:57:26 PDT
We should also treat CRLF as one character per the recent spec change if we haven't done so.
Note You need to log in before you can comment on or make changes to this bug.