Bug 161641

Summary:

[iOS] Remove soft linking of MobileCoreServices.framework

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, mitz, mmaxfield, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2016-09-06 12:57:00 PDT

Since MobileCoreServices.framework does not depend on WebCore.framework, and there is no longer a penalty for linking frameworks (until a symbol is used), we can get rid of the eight places where MobileCoreServices.framework is soft-linked in WebCore for iOS (one of which isn't even used any longer).

Attachments
Patch v1 (15.89 KB, patch) 2016-09-06 13:45 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2016-09-06 12:57:18 PDT

<rdar://problem/10420118>

David Kilzer (:ddkilzer)

Comment 2 2016-09-06 13:45:06 PDT

Created attachment 288042 [details] Patch v1

Darin Adler

Comment 3 2016-09-06 15:59:04 PDT

Comment on attachment 288042 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=288042&action=review > Source/WebCore/ChangeLog:9 > + * Configurations/WebCore.xcconfig: Add hard link to "hard link" is a term of art that normally means the thing the "ln" command creates So I would have used different wording here.

WebKit Commit Bot

Comment 4 2016-09-06 16:03:52 PDT

Comment on attachment 288042 [details] Patch v1 Clearing flags on attachment: 288042 Committed r205516: <http://trac.webkit.org/changeset/205516>

WebKit Commit Bot

Comment 5 2016-09-06 16:03:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.