Summary: | [Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebCore Misc. | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, jer.noble | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-09-05 01:47:21 PDT
Created attachment 287942 [details]
[PATCH] Proposed Fix
Jer, could we write a test for this?
Comment on attachment 287942 [details]
[PATCH] Proposed Fix
Wow, seems like this also fixes a bug, not just a static analyzer warning! I wonder if someone knows how to write a test that would demonstrate the bug.
Also, I would like to remind everyone that in new code we should model multiple return values as return value, perhaps using a combination of structures, tuples, pairs, optionals, and variants as needed, not as one return value and two out arguments.
I see Joe’s question/request to Jer now. Comment on attachment 287942 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287942 Committed r205456: <http://trac.webkit.org/changeset/205456> All reviewed patches have been landed. Closing bug. |