Bug 161590

Summary:	[GTK] Layout test editing/inserting/typing-space-to-trigger-smart-link.html fails
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, jbedard, mcatanzaro, rniwa
Priority:	P2
Version:	Other
Hardware:	PC
OS:	Linux
See Also:	https://bugs.webkit.org/show_bug.cgi?id=85463 https://bugs.webkit.org/show_bug.cgi?id=162081 https://bugs.webkit.org/show_bug.cgi?id=161919

Description Michael Catanzaro 2016-09-04 20:09:37 PDT

Layout test editing/inserting/typing-space-to-trigger-smart-link.html has been failing since it was unskipped in r205094 ("WTR needs an implementation of setAutomaticLinkDetectionEnabled"):

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/inserting/typing-space-to-trigger-smart-link-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/editing/inserting/typing-space-to-trigger-smart-link-actual.txt
@@ -1,4 +1,4 @@
 The www.foo.com should be underlined and there is an anchor node created for it.
 The www.bar.com should be underlined and there is an anchor node created for it.
-PASS: the anchor for 'www.foo.com' has been created.
-PASS: the anchor for 'www.bar.com' has been created.
+Failed: the expected content was 'The <a href="http://www.foo.com">www.foo.com</a> should be underlined and there is an anchor node created for it.', but the actual result was 'The www.foo.com should be underlined and there is an anchor node created for it.'.
+Failed: the expected content was 'The <a href="http://www.bar.com">www.bar.com</a> should be underlined and there is an anchor node created for it.', but the actual result was 'The www.bar.com should be underlined and there is an anchor node created for it.'.

Obviously the link is missing. Updating expectations accordingly.

Comment 1 Ryosuke Niwa 2016-09-16 13:12:10 PDT

GTK+ port doesn't enable smart space, right?  So I think we just need to skip the test.

Comment 2 Ryosuke Niwa 2016-09-16 13:12:22 PDT

Sorry, I meant to say smart link.

Comment 3 Jonathan Bedard 2016-09-16 13:22:13 PDT

Yes, I was closing this bug and noting so when our comments collided.

This is caused by a failure to call setAuomaticLinkDetection.  However, setAutomaticLinkDetection is an AppKit specific feature.  This test should not run on GTK.

Comment 4 Michael Catanzaro 2016-09-16 13:32:41 PDT

(In reply to comment #3)
> Yes, I was closing this bug and noting so when our comments collided.
> 
> This is caused by a failure to call setAuomaticLinkDetection.  However,
> setAutomaticLinkDetection is an AppKit specific feature.  This test should
> not run on GTK.

Then Ryosuke is right, we need to skip it!

Comment 5 Jonathan Bedard 2016-09-16 13:41:10 PDT

(In reply to comment #4)
> Then Ryosuke is right, we need to skip it!
> ...

https://bugs.webkit.org/show_bug.cgi?id=161919 will have this change shortly, along with skipping this class of test on iOS, EFL and Windows.

Comment 6 Michael Catanzaro 2016-09-16 18:02:41 PDT

(In reply to comment #5)
> (In reply to comment #4)
> > Then Ryosuke is right, we need to skip it!
> > ...
> 
> https://bugs.webkit.org/show_bug.cgi?id=161919 will have this change
> shortly, along with skipping this class of test on iOS, EFL and Windows.

Thanks. Since it's macOS specific, you might skip it in the global test expectations, and add a Pass expectation in the macOS file.