Bug 161585

Summary: [GTK] Layout test accessibility/media-emits-object-replacement.html fails
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jdiggs, mcatanzaro, n_wang, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Updated patch none

Michael Catanzaro
Reported 2016-09-04 19:41:57 PDT
Layout test accessibility/media-emits-object-replacement.html has been broken since it was modified in r203913 ("AX: Media controls accessibility improvement): --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/media-emits-object-replacement-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/media-emits-object-replacement-actual.txt @@ -6,14 +6,14 @@ AXRole: AXSection AXValue: a <obj> b AXRole: AXVideo AXRole: AXToolbar - AXRole: AXCheckBox + AXRole: AXButton AXRole: AXSlider AXRole: AXTimer AXValue: 00:00 AXRole: AXSection AXValue: <\n> AXRole: AXSection AXValue: a <obj> b AXRole: AXAudio AXRole: AXToolbar - AXRole: AXCheckBox + AXRole: AXButton AXRole: AXSlider AXRole: AXTimer AXValue: 00:00 AXRole: AXSection AXValue: End of test Updating expectations accordingly.
Attachments
Patch (1.66 KB, patch)
2016-09-06 17:03 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Updated patch (2.36 KB, patch)
2016-09-06 17:21 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-04 19:42:10 PDT
<rdar://problem/28157032>
Nan Wang
Comment 2 2016-09-06 17:03:02 PDT
Created attachment 288068 [details] Patch
Michael Catanzaro
Comment 3 2016-09-06 17:11:55 PDT
Thanks, I didn't realize we just needed to update the expected results file. The patch should remove the failure expectation in LayoutTests/platform/gtk/TestExpectations as well.
Nan Wang
Comment 4 2016-09-06 17:21:30 PDT
Created attachment 288071 [details] Updated patch Remove the failure expectation in TestExpectations
WebKit Commit Bot
Comment 5 2016-09-07 10:14:54 PDT
Comment on attachment 288071 [details] Updated patch Clearing flags on attachment: 288071 Committed r205553: <http://trac.webkit.org/changeset/205553>
WebKit Commit Bot
Comment 6 2016-09-07 10:14:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.