Bug 161585 – [GTK] Layout test accessibility/media-emits-object-replacement.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Michael Catanzaro]

Layout test accessibility/media-emits-object-replacement.html has been broken since it was modified in r203913 ("AX: Media controls accessibility improvement):

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/media-emits-object-replacement-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/media-emits-object-replacement-actual.txt
@@ -6,14 +6,14 @@
     AXRole: AXSection AXValue: a <obj> b
         AXRole: AXVideo 
             AXRole: AXToolbar 
-                AXRole: AXCheckBox 
+                AXRole: AXButton 
                 AXRole: AXSlider 
                 AXRole: AXTimer AXValue: 00:00
     AXRole: AXSection AXValue: <\n>
     AXRole: AXSection AXValue: a <obj> b
         AXRole: AXAudio 
             AXRole: AXToolbar 
-                AXRole: AXCheckBox 
+                AXRole: AXButton 
                 AXRole: AXSlider 
                 AXRole: AXTimer AXValue: 00:00
     AXRole: AXSection AXValue: End of test

Updating expectations accordingly.

[Radar WebKit Bug Importer]

<rdar://problem/28157032>

[Nan Wang]

Created attachment 288068 [details]
Patch

[Michael Catanzaro]

Thanks, I didn't realize we just needed to update the expected results file.

The patch should remove the failure expectation in LayoutTests/platform/gtk/TestExpectations as well.

[Nan Wang]

Created attachment 288071 [details]
Updated patch

Remove the failure expectation in TestExpectations

[WebKit Commit Bot]

Comment on attachment 288071 [details]
Updated patch

Clearing flags on attachment: 288071

Committed r205553: <http://trac.webkit.org/changeset/205553>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.