Bug 161580

Summary: Remove the CREATE_DOM_WRAPPER macro
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, cgarcia, commit-queue, dbates, dino, esprehn+autocc, graouts, jsbell, kangil.han, kondapallykalyan, mcatanzaro, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Sam Weinig
Reported 2016-09-04 18:11:20 PDT
Remove the CREATE_DOM_WRAPPER macro
Attachments
Patch (43.62 KB, patch)
2016-09-04 18:20 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-09-04 18:20:35 PDT
Created attachment 287924 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-04 18:22:34 PDT
Attachment 287924 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:484: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2016-09-04 18:22:45 PDT
I thought about doing this in the other direction, making it createWrapper<WrapperType>(...), but couldn't convince myself one way was better than another, so I went this way. I have plans to use the mapping established by JSDOMWrapperConverterTraits for more things going forward, so this seems ok.
Sam Weinig
Comment 4 2016-09-04 20:13:51 PDT
Committed r205422: <http://trac.webkit.org/changeset/205422>
Csaba Osztrogonác
Comment 5 2016-09-05 00:08:25 PDT
(In reply to comment #4) > Committed r205422: <http://trac.webkit.org/changeset/205422> It broke the bindings generation tests, pleasw fix them.
Note You need to log in before you can comment on or make changes to this bug.