Summary: | Remove the CREATE_DOM_WRAPPER macro | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alecflett, beidson, cdumez, cgarcia, commit-queue, dbates, dino, esprehn+autocc, graouts, jsbell, kangil.han, kondapallykalyan, mcatanzaro, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sam Weinig
2016-09-04 18:11:20 PDT
Created attachment 287924 [details]
Patch
Attachment 287924 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:484: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I thought about doing this in the other direction, making it createWrapper<WrapperType>(...), but couldn't convince myself one way was better than another, so I went this way. I have plans to use the mapping established by JSDOMWrapperConverterTraits for more things going forward, so this seems ok. Committed r205422: <http://trac.webkit.org/changeset/205422> (In reply to comment #4) > Committed r205422: <http://trac.webkit.org/changeset/205422> It broke the bindings generation tests, pleasw fix them. |