Bug 161565

Summary:

Web Inspector: Address ESLint undefined variable errors in UserInterface/Views

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2016-09-02 20:16:57 PDT

Address ESLint undefined variable errors in UserInterface/Views:

    Source/WebInspectorUI/UserInterface/Views/DataGrid.js
       873:19  error  'identifier' is defined but never used                no-unused-vars
       875:20  error  'columnIdentifier' is not defined                     no-undef

    Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
      1018:50  error  'breakpoint' is not defined            no-undef

    Source/WebInspectorUI/UserInterface/Views/TextContentView.js
      154:13  error  'activated' is defined but never used  no-unused-vars
      155:47  error  'formatted' is not defined             no-undef

Real issues that would cause runtime exceptions.

Comment 1 Joseph Pecoraro 2016-09-02 20:17:38 PDT

Created attachment 287851 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2016-09-03 07:40:33 PDT

Comment on attachment 287851 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287851

Committed r205401: <http://trac.webkit.org/changeset/205401>

Comment 3 WebKit Commit Bot 2016-09-03 07:40:36 PDT

All reviewed patches have been landed.  Closing bug.