| Summary: | Web Inspector: Address ESLint undefined variable errors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 287849 [details]
[PATCH] Proposed Fix
Attachment 287849 [details] did not pass style-queue:
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:586: Line contains single-quote character. [js/syntax] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 287849 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287849 Committed r205402: <http://trac.webkit.org/changeset/205402> All reviewed patches have been landed. Closing bug. |
Address ESLint undefined variable errors: Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js 86:65 error 'origin' is not defined no-undef Source/WebInspectorUI/UserInterface/Models/IssueMessage.js 73:52 error 'source' is not defined no-undef Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js 586:169 error 'args' is not defined no-undef These are all legit errors. Fortunately there are in handling error conditions that shouldn't be reached!