Bug 161562

Summary: Unbreak customElements.whenDefined after r205383 with a crash fix
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ggaren, kangil.han, kling, koivisto, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Reverts r205383 and fixes the crash none

Ryosuke Niwa
Reported 2016-09-02 19:00:45 PDT
Fix whenDefined with a crash fix after https://trac.webkit.org/changeset/205383.
Attachments
Reverts r205383 and fixes the crash (6.58 KB, patch)
2016-09-02 19:10 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-02 19:01:43 PDT
<rdar://problem/28146962>
Ryosuke Niwa
Comment 2 2016-09-02 19:10:18 PDT
Created attachment 287848 [details] Reverts r205383 and fixes the crash
Ryosuke Niwa
Comment 3 2016-09-03 16:06:35 PDT
Comment on attachment 287848 [details] Reverts r205383 and fixes the crash Thanks for the review! I'll monitor https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdom%2FAttr%2Faccess-after-element-destruction.html to make sure this doesn't reintroduce the crash.
WebKit Commit Bot
Comment 4 2016-09-03 16:27:43 PDT
Comment on attachment 287848 [details] Reverts r205383 and fixes the crash Clearing flags on attachment: 287848 Committed r205410: <http://trac.webkit.org/changeset/205410>
WebKit Commit Bot
Comment 5 2016-09-03 16:27:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.