Summary: | [Mac] Remove unnecessary RetainPtr in NeverDestroyed value | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | WebCore Misc. | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dbates | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-09-02 15:25:36 PDT
Created attachment 287825 [details]
[PATCH] Proposed Fix
Comment on attachment 287825 [details]
[PATCH] Proposed Fix
Typo.
Created attachment 287827 [details]
[PATCH] Proposed Fix
Comment on attachment 287827 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287827&action=review > Source/WebCore/platform/ios/WebCoreMotionManager.mm:71 > + static NeverDestroyed<WebCoreMotionManager *> sharedMotionManager([[WebCoreMotionManager alloc] init]); > + return sharedMotionManager.get(); Alternatively this could just be: static WebCoreMotionManager* sharedManager = [[WebCoreMotionManager alloc] init]; return sharedMotionManager; Which I think is probably the best. So I'll just write a patch for that! Created attachment 287829 [details]
[PATCH] Proposed Fix
Comment on attachment 287829 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287829 Committed r205391: <http://trac.webkit.org/changeset/205391> All reviewed patches have been landed. Closing bug. Comment on attachment 287829 [details]
[PATCH] Proposed Fix
Should we grep for NeverDestroyed and RetainPtr on the same line?
|