Bug 161553

Summary:

[Mac] Remove unnecessary RetainPtr in NeverDestroyed value

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	joepeck: review-
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-09-02 15:25:36 PDT

Remove unnecessary RetainPtr in NeverDestroyed value: WebCore/platform/ios/WebCoreMotionManager.mm 72: static NeverDestroyed<RetainPtr<WebCoreMotionManager>> sharedMotionManager([[WebCoreMotionManager alloc] init]); The NeverDestroyed can just hold the allocated pointer.

Attachments
[PATCH] Proposed Fix (1.47 KB, patch) 2016-09-02 15:26 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (1.47 KB, patch) 2016-09-02 15:42 PDT, Joseph Pecoraro	joepeck: review-	Details Formatted Diff Diff
[PATCH] Proposed Fix (1.45 KB, patch) 2016-09-02 15:44 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-09-02 15:26:37 PDT

Created attachment 287825 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 2 2016-09-02 15:27:53 PDT

Comment on attachment 287825 [details] [PATCH] Proposed Fix Typo.

Joseph Pecoraro

Comment 3 2016-09-02 15:42:06 PDT

Created attachment 287827 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 4 2016-09-02 15:43:07 PDT

Comment on attachment 287827 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287827&action=review > Source/WebCore/platform/ios/WebCoreMotionManager.mm:71 > + static NeverDestroyed<WebCoreMotionManager *> sharedMotionManager([[WebCoreMotionManager alloc] init]); > + return sharedMotionManager.get(); Alternatively this could just be: static WebCoreMotionManager* sharedManager = [[WebCoreMotionManager alloc] init]; return sharedMotionManager; Which I think is probably the best. So I'll just write a patch for that!

Joseph Pecoraro

Comment 5 2016-09-02 15:44:47 PDT

Created attachment 287829 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 6 2016-09-02 17:36:20 PDT

Comment on attachment 287829 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287829 Committed r205391: <http://trac.webkit.org/changeset/205391>

WebKit Commit Bot

Comment 7 2016-09-02 17:36:24 PDT

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 8 2016-09-03 07:26:42 PDT

Comment on attachment 287829 [details] [PATCH] Proposed Fix Should we grep for NeverDestroyed and RetainPtr on the same line?

Note You need to log in before you can comment on or make changes to this bug.