Bug 161551

Summary: [Mac] RetainPtr misuse, DDActionContext leaks
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Joseph Pecoraro <joepeck>
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2016-09-02 15:04:38 PDT
RetainPtr misuse, DDActionContext leaks

    $ ack 'RetainPtr.*?alloc' | grep -v adopt
    WebKit2/Platform/mac/MenuUtilities.mm:56:    RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];
    WebKit2/Platform/mac/MenuUtilities.mm:87:    RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];

These should be adopted.
Comment 1 Joseph Pecoraro 2016-09-02 15:05:12 PDT
Created attachment 287821 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-09-02 15:44:26 PDT
Comment on attachment 287821 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287821

Committed r205377: <http://trac.webkit.org/changeset/205377>
Comment 3 WebKit Commit Bot 2016-09-02 15:44:30 PDT
All reviewed patches have been landed.  Closing bug.