Bug 161551 - [Mac] RetainPtr misuse, DDActionContext leaks
Summary: [Mac] RetainPtr misuse, DDActionContext leaks
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
Depends on:
Reported: 2016-09-02 15:04 PDT by Joseph Pecoraro
Modified: 2016-09-02 15:44 PDT (History)
2 users (show)

See Also:

[PATCH] Proposed Fix (2.16 KB, patch)
2016-09-02 15:05 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-02 15:04:38 PDT
RetainPtr misuse, DDActionContext leaks

    $ ack 'RetainPtr.*?alloc' | grep -v adopt
    WebKit2/Platform/mac/MenuUtilities.mm:56:    RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];
    WebKit2/Platform/mac/MenuUtilities.mm:87:    RetainPtr<DDActionContext> actionContext = [[getDDActionContextClass() alloc] init];

These should be adopted.
Comment 1 Joseph Pecoraro 2016-09-02 15:05:12 PDT
Created attachment 287821 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-09-02 15:44:26 PDT
Comment on attachment 287821 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287821

Committed r205377: <http://trac.webkit.org/changeset/205377>
Comment 3 WebKit Commit Bot 2016-09-02 15:44:30 PDT
All reviewed patches have been landed.  Closing bug.