Bug 161549

Summary: REGRESSION: LayoutTest fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: WebKit Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, jonlee, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173779
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2016-09-02 14:46:42 PDT
LayoutTest fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky failure https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20(Tests)/builds/14759 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fscrolling%2Farrow-key-scroll-in-rtl-document.html --- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt +++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-actual.txt @@ -1 +1 @@ -PASS: scrollLeft is -120 +FAIL: scrollLeft is 0, expected -120
Attachments
Patch (2.46 KB, patch)
2017-06-02 12:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-09-02 14:47:55 PDT
The first failure according to the dashboard is ~r204242, but that change itself seems unrelated.
Alexey Proskuryakov
Comment 2 2016-09-08 13:55:33 PDT
<rdar://problem/28213429>
Alexey Proskuryakov
Comment 3 2016-09-20 21:54:34 PDT
I see failures older than that, but they definitely became more frequent recently.
Ryan Haddad
Comment 4 2017-04-18 12:42:52 PDT
According to the flakiness dashboard, this test is still flaky on Sierra WK2 with the same diff.
Chris Dumez
Comment 5 2017-06-02 12:12:35 PDT
Created attachment 311843 [details] Patch
Chris Dumez
Comment 6 2017-06-02 12:13:31 PDT
Was able to reproduce the flakiness locally via: Tools/Scripts/run-webkit-tests --release --repeat-each=100 fast/scrolling/arrow-key-scroll-in-rtl-document.html -g Flakiness is gone with proposed change.
Chris Dumez
Comment 7 2017-06-02 12:57:19 PDT
Comment on attachment 311843 [details] Patch Clearing flags on attachment: 311843 Committed r217731: <http://trac.webkit.org/changeset/217731>
Chris Dumez
Comment 8 2017-06-02 12:57:20 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 9 2017-06-02 13:41:42 PDT
Is it understood why delaying on a timer is necessary here? Can we make tests resilient against this kind of mistake?
Note You need to log in before you can comment on or make changes to this bug.