Bug 161541

Summary:

GetByValWithThis: fix opInfo in DFG creation

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

JavaScriptCore

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description JF Bastien 2016-09-02 12:02:20 PDT

See: https://bugs.webkit.org/show_bug.cgi?id=160922#c7
Saam points out that I addToGraph with the first opInfo instead of the second. IIUC that pipes into DFG's Node class, whose getHeapPrediction() does: return m_opInfo2.as<SpeculatedType>();

Comment 1 JF Bastien 2016-09-02 12:05:30 PDT

Created attachment 287792 [details]
patch

Perf numbers are pretty noisy, it seems 1.0148x faster or so.

Comment 2 WebKit Commit Bot 2016-09-02 12:19:21 PDT

Comment on attachment 287792 [details]
patch

Clearing flags on attachment: 287792

Committed r205361: <http://trac.webkit.org/changeset/205361>

Comment 3 WebKit Commit Bot 2016-09-02 12:19:26 PDT

All reviewed patches have been landed.  Closing bug.