Bug 161522

Summary: Add toJS for JSC::PrivateName
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, rniwa, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148897    
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

Yusuke Suzuki
Reported 2016-09-01 19:51:19 PDT
Add toJS for JSC::PrivateName
Attachments
Patch (3.56 KB, patch)
2016-09-01 19:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.99 KB, patch)
2016-09-01 20:23 PDT, Yusuke Suzuki 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-09-01 19:53:43 PDT
Created attachment 287717 [details] Patch
Yusuke Suzuki
Comment 2 2016-09-01 19:54:45 PDT
Comment on attachment 287717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287717&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:581 > + return JSC::Symbol::create(exec->vm(), *privateName.uid()); I'll update this uid() to return reference.
WebKit Commit Bot
Comment 3 2016-09-01 19:55:22 PDT
Attachment 287717 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 4 2016-09-01 20:23:09 PDT
Created attachment 287721 [details] Patch
Ryosuke Niwa
Comment 5 2016-09-01 20:30:18 PDT
Comment on attachment 287721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287721&action=review > Source/JavaScriptCore/ChangeLog:8 > + Add the export annotation. Why are you making hold Ref instead of RefPtr? Is that an unrelated refactoring? Please clarify that in the channel log before landing this.
Yusuke Suzuki
Comment 6 2016-09-01 20:37:05 PDT
Comment on attachment 287721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287721&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Add the export annotation. > > Why are you making hold Ref instead of RefPtr? Is that an unrelated refactoring? > Please clarify that in the channel log before landing this. Thanks. I noted that.
Yusuke Suzuki
Comment 7 2016-09-01 20:44:06 PDT
Committed r205335: <http://trac.webkit.org/changeset/205335>
Note You need to log in before you can comment on or make changes to this bug.