Summary: | jsc: fix cmake build missing symbol getPropertySlot | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||||
Component: | JavaScriptCore | Assignee: | JF Bastien <jfbastien> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
JF Bastien
2016-09-01 18:23:46 PDT
Created attachment 287710 [details]
patch
Comment on attachment 287710 [details]
patch
But these are marked ALWAYS_INLINE. I believe that there are a few places where we actually rely on them being inlined.
You should carefully test performance with such a change. I'm happy to r+ if you've run JetStream, Speedometer, and PLT3.
Created attachment 287713 [details]
patch
Fixed by including JSCInlines.h instead of moving things to .cpp file (Fil and others pointed out that this would have perf implications, etc).
This also fixes the cmake build.
Attachment 287713 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 287713 [details]
patch
r=me
I'm going to let EWS build before cq+
Comment on attachment 287713 [details] patch Clearing flags on attachment: 287713 Committed r205332: <http://trac.webkit.org/changeset/205332> All reviewed patches have been landed. Closing bug. |