Bug 161499 - Move some JSObject and JSArray inline functions to their respective Inlines.h files.
Summary: Move some JSObject and JSArray inline functions to their respective Inlines.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 161498
  Show dependency treegraph
 
Reported: 2016-09-01 11:40 PDT by Mark Lam
Modified: 2016-09-01 15:37 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (19.41 KB, patch)
2016-09-01 11:56 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch (19.96 KB, patch)
2016-09-01 12:32 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (21.89 KB, patch)
2016-09-01 14:10 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (23.51 KB, patch)
2016-09-01 14:56 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-09-01 11:40:44 PDT
Patch coming.
Comment 1 Mark Lam 2016-09-01 11:56:40 PDT
Created attachment 287650 [details]
proposed patch.

Let's try it on the EWS.
Comment 2 Mark Lam 2016-09-01 12:32:50 PDT
Created attachment 287654 [details]
proposed patch
Comment 3 Mark Lam 2016-09-01 13:25:29 PDT
Comment on attachment 287654 [details]
proposed patch

So strange.  The build finishes on my local machine without issues.  I'm re-try with a clean build now.
Comment 4 Mark Lam 2016-09-01 14:10:55 PDT
Created attachment 287677 [details]
proposed patch.
Comment 5 Mark Lam 2016-09-01 14:56:41 PDT
Created attachment 287686 [details]
proposed patch.
Comment 6 Mark Lam 2016-09-01 15:37:35 PDT
Thanks for the review.  Landed in r205324: <http://trac.webkit.org/r205324>.