Bug 161510

Summary: Web Inspector: NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined
Product: WebKit Reporter: Johan K. Jensen <jj>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Johan K. Jensen
Reported 2016-09-01 14:25:08 PDT
WebInspector.NetworkTimelineOverviewGraph.MinimumBarPaddingTime is undefined which causes new network record bars to be always be dumped on the next row in the NetworkTimelineOverview instead of rows where they might be able to fit in.
Attachments
Patch (4.92 KB, patch)
2016-09-01 14:36 PDT, Johan K. Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-01 14:25:30 PDT
<rdar://problem/28123169>
Johan K. Jensen
Comment 2 2016-09-01 14:36:49 PDT
Created attachment 287682 [details] Patch
Blaze Burg
Comment 3 2016-09-01 16:28:03 PDT
Comment on attachment 287682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287682&action=review r=me > Source/WebInspectorUI/ChangeLog:12 > + by using MinimumWidthPixel, MinimumMarginPixel and MinimumDurationPerPixel as the secondsPerPixel value. I do not know if similar values are used by network overview, as it is a different algorithm. But it seems more sensible that giving up.
WebKit Commit Bot
Comment 4 2016-09-02 10:48:08 PDT
Comment on attachment 287682 [details] Patch Clearing flags on attachment: 287682 Committed r205349: <http://trac.webkit.org/changeset/205349>
WebKit Commit Bot
Comment 5 2016-09-02 10:48:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.