Bug 161484

Summary: [GTK] GL_PACK_ROW_LENGTH is not available in GLES2
Product: WebKit Reporter: memeka <mihailescu2m>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, emanuele.aina, gustavo
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

memeka
Reported 2016-09-01 04:28:04 PDT
Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp AcceleratedBackingStoreWayland::paint makes use of GL_PACK_ROW_LENGTH, which is missing in many (egl/gles) platforms
Attachments
Patch (2.95 KB, patch)
2016-09-02 11:43 PDT, Gustavo Noronha (kov) 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
memeka
Comment 1 2016-09-01 04:54:14 PDT
for my GPU (mali 768) i found GL_PACK_ROW_LENGTH is a GLES3 function in GLES3/gl3.h: #ifndef GL_ES_VERSION_3_0 #define GL_ES_VERSION_3_0 1 typedef unsigned short GLhalf; #define GL_READ_BUFFER 0x0C02 #define GL_UNPACK_ROW_LENGTH 0x0CF2 #define GL_UNPACK_SKIP_ROWS 0x0CF3 #define GL_UNPACK_SKIP_PIXELS 0x0CF4 #define GL_PACK_ROW_LENGTH 0x0D02 ... but maybe it should be replaced by a GLES2 function for better compatibility.
Gustavo Noronha (kov)
Comment 2 2016-09-02 11:43:26 PDT
Created attachment 287790 [details] Patch
Gustavo Noronha (kov)
Comment 3 2016-09-05 07:24:16 PDT
Committed r205452: <http://trac.webkit.org/changeset/205452>
Note You need to log in before you can comment on or make changes to this bug.