Bug 161482
Summary: | [GStreamer] build fails with ACCELERATED_2D_CANVAS disabled | ||
---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> |
Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | zan |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Philippe Normand
We have:
#if USE(CAIRO) && ENABLE(ACCELERATED_2D_CANVAS)
#include <cairo-gl.h>
#endif
but in MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime():
#if !USE(CAIRO) || !ENABLE(ACCELERATED_2D_CANVAS)
return nullptr;
#endif
I think the ifdef wrapping the #include should be USE(CAIRO) && ENABLE(OPENGL) or something similar.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Philippe Normand
The build error is that cairo_gl_device_set_thread_aware() isn't found because cairo-gl.h isn't included.
Zan Dobersek
*** This bug has been marked as a duplicate of bug 161594 ***