Bug 161476

Summary: YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
Product: WebKit Reporter: Ricky Mondello <rmondello>
Component: WebCore Misc.Assignee: Ricky Mondello <rmondello>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eric.carlson, jonlee, sam, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
first attempt
eric.carlson: review+
same as last time, with a few renames none

Ricky Mondello
Reported 2016-08-31 23:21:37 PDT
YouTube Flash plug-in replacement facility should more gracefully handle malformed queries Some YouTube Flash embeds use '&' instead of '?' to start the query portion of the URL. Here's an example: http://www.youtube.com/v/dQw4w9WgXcQ&start=4 Our implementation drops everything including and after the &. Instead, we should treat the & like a ? and restore the query when we're done. If we do this, it means embeds for a particular timecode will be preserved.
Attachments
first attempt (9.88 KB, patch)
2016-08-31 23:38 PDT, Ricky Mondello 		eric.carlson: review+
DetailsFormatted DiffDiff
same as last time, with a few renames (10.06 KB, patch)
2016-09-01 11:37 PDT, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ricky Mondello
Comment 1 2016-08-31 23:38:16 PDT
Created attachment 287604 [details] first attempt
Eric Carlson
Comment 2 2016-09-01 09:30:32 PDT
Comment on attachment 287604 [details] first attempt View in context: https://bugs.webkit.org/attachment.cgi?id=287604&action=review > Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:203 > +static URL processAndCreateYouTubeURL(const URL& url, bool& isYouTubeShortenedURL, String& outMalformedQuery) "malformedQuery" doesn't seem right, although I don't have any great suggestions. Maybe "unusedParameters"?
Ricky Mondello
Comment 3 2016-09-01 11:37:15 PDT
Created attachment 287643 [details] same as last time, with a few renames
WebKit Commit Bot
Comment 4 2016-09-01 12:29:53 PDT
Comment on attachment 287643 [details] same as last time, with a few renames Clearing flags on attachment: 287643 Committed r205306: <http://trac.webkit.org/changeset/205306>
WebKit Commit Bot
Comment 5 2016-09-01 12:29:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.