Summary: | YouTube Flash plug-in replacement facility should more gracefully handle malformed queries | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ricky Mondello <rmondello> | ||||||
Component: | WebCore Misc. | Assignee: | Ricky Mondello <rmondello> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, eric.carlson, jonlee, sam, simon.fraser, thorton | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ricky Mondello
2016-08-31 23:21:37 PDT
Created attachment 287604 [details]
first attempt
Comment on attachment 287604 [details] first attempt View in context: https://bugs.webkit.org/attachment.cgi?id=287604&action=review > Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:203 > +static URL processAndCreateYouTubeURL(const URL& url, bool& isYouTubeShortenedURL, String& outMalformedQuery) "malformedQuery" doesn't seem right, although I don't have any great suggestions. Maybe "unusedParameters"? Created attachment 287643 [details]
same as last time, with a few renames
Comment on attachment 287643 [details] same as last time, with a few renames Clearing flags on attachment: 287643 Committed r205306: <http://trac.webkit.org/changeset/205306> All reviewed patches have been landed. Closing bug. |