Bug 161465

Summary: [Mac] Web Inspector: Remove stale inspector process termination code
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2016-08-31 16:38:42 PDT
Remove stale inspector process termination code

This code doesn't appear to get run when the WebContentProcess inside of an Inspector Process gets killed.

Instead the general WebInspectorProxy webProcessDidCrash closes the proxy. So this code appears to be unreachable and stale.
Comment 1 Radar WebKit Bug Importer 2016-08-31 16:39:17 PDT
Comment 2 Joseph Pecoraro 2016-08-31 16:41:12 PDT
Created attachment 287564 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-09-01 10:49:48 PDT
Comment on attachment 287564 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=287564&action=review


> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:-165
> -- (void)_didRelaunchProcess

This is an override from WKWebViewPrivate, but the base implementation only does anything for iOS, and it's only called from PageClientImplIOS.mm. I wonder why we went this route...
Comment 4 WebKit Commit Bot 2016-09-01 11:10:47 PDT
Comment on attachment 287564 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287564

Committed r205299: <http://trac.webkit.org/changeset/205299>
Comment 5 WebKit Commit Bot 2016-09-01 11:10:51 PDT
All reviewed patches have been landed.  Closing bug.