Summary: | FocusController should pass KeyboardEvent around by reference. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2016-08-31 15:07:49 PDT
Created attachment 287548 [details]
Patch
Attachment 287548 [details] did not pass style-queue:
ERROR: Source/WebCore/page/FocusController.cpp:399: 'event' is incorrectly named. It should be named 'protector' or 'protectedProvidedEvent'. [readability/naming/protected] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 287548 [details] Patch Clearing flags on attachment: 287548 Committed r205290: <http://trac.webkit.org/changeset/205290> All reviewed patches have been landed. Closing bug. |